This repository was archived by the owner on Sep 30, 2024. It is now read-only.
upgrade Cody Web, always create a new chat#64334
Merged
Merged
Conversation
73258f7 to
9147d29
Compare
evict
approved these changes
Aug 7, 2024
fkling
approved these changes
Aug 7, 2024
Comment on lines
170
to
172
Contributor
There was a problem hiding this comment.
This won't have any effect here because there is no element in this component that has attribute [cmdk-root]. Instead this needs to be moved underneath .chat and changed to
:global([cmdk-root]) :global(.focus-visible) {
box-shadow: unset !important;
}
Member
Author
There was a problem hiding this comment.
Thanks. But hmm, that doesn't seem to work either. I am trying to get rid of the blue focus ring that the arrow is pointing to (just the one below the text field):
Member
Author
There was a problem hiding this comment.
ah, I got it. It was using input:focus-visible not the .focus-visible JS helper in client/web
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporates https://github.com/sourcegraph/cody/pull/5129
Test plan
Run in SvelteKit and non-SvelteKit. Ensure that the Cody standalone chat and Cody sidebar chats work.