This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix: Try workaround for bad index choice when updating execution logs#64328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under high contention, the updating of execution logs query:
Was taking multiple seconds due to lock contention on the lsif_indexes_state index.
Running
EXPLAIN ANALYZEon Sourcegraph.com under lower contention usesthe primary key index on id, so we don't have an easy way to test the high contention
scenario. Try this alternate query form to see if that fixes the issue.
Test plan
Existing tests continue to pass.
Slowly increase executor count back to 160 and see if lock contention comes up again.