This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(svelte): Better preloading in file tree#64327
Merged
Merged
Conversation
Currently the link element doesn't extend to the full width of the sidebar. You can still click outside of the actual text to navigate to the file, but it won't be preloaded. Now the link occupies the full width.
fkling
commented
Aug 7, 2024
Comment on lines
-188
to
-189
| text-overflow: ellipsis; | ||
| overflow: hidden; |
Contributor
Author
There was a problem hiding this comment.
This didn't seem to have any effect, even without the setting width: 100% above.
umpox
approved these changes
Aug 7, 2024
varungandhi-src
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the link element doesn't extend to the full width of the sidebar. You can click outside of the actual text to navigate to the file, but it won't be preloaded.
Now the link occupies the full width.
Test plan
Manual testing.