This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Fix Cody Web Svelte Sidebar#64320
Merged
Merged
Conversation
fkling
approved these changes
Aug 7, 2024
|
|
||
| <style lang="scss"> | ||
| :root { | ||
| --vscode-sideBar-background: transparent; |
Contributor
There was a problem hiding this comment.
I think it's probably fine to define/restrict this to .chat. :root is probably not necessary.
Contributor
Author
There was a problem hiding this comment.
I copied it from the chat UI in react implementation. Let me try with scoping it to .chat
Contributor
Author
There was a problem hiding this comment.
yeah that worked as well.
Contributor
There was a problem hiding this comment.
Yeah I don't know why we use :root there but I generally think we should attach less things to :root :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cody's Web Sidebar in Svelte is not following the theme when tested locally.
This PR fixes that. I have tested this with multiple builds both with & without the diff.
Test plan
Before:
After:
Changelog