This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore: Replace QueuedCount -> CountByState with bitset parameter#64302
Merged
Conversation
c9dee0d to
3834b19
Compare
3834b19 to
788b76e
Compare
Previously, the QueuedCount method was confusing because: 1. By default, it actually returned the count for both the 'queued' and 'errored' states (despite the name just have 'Queued'). 2. There was an additional boolean flag for also returning entries in the 'processing' state, but reduced clarity at call-sites. So I've changed the method to take a bitset instead, mirroring the just-added Exists API, and renamed the method to a more generic 'CountByState'. While this does make call-sites a bit more verbose, I think the clarity win makes the change an overall positive one.
788b76e to
96e9b3a
Compare
eseliger
approved these changes
Aug 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the QueuedCount method was confusing because:
(despite the name just have 'Queued').
but reduced clarity at call-sites.
So I've changed the method to take a bitset instead, mirroring the just-added Exists API,
and renamed the method to a more generic 'CountByState'.
While this does make call-sites a bit more verbose,
I think the clarity win makes the change an overall positive one.
However, if there is strong opposition, I'm open to re-considering/closing this PR.
This PR is stacked on top of:
Test plan
Covered by existing tests.
At the moment, there is some breakage in one test, I think that's because
of the change in the base PR, I'll take a look into that if this PR is
deemed directionally correct.