This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Search: boost matches on quoted terms#64298
Merged
Merged
Conversation
Contributor
Author
|
Some notes:
|
00a27df to
4a52dae
Compare
stefanhengl
approved these changes
Aug 6, 2024
| autogold.Expect(`(or "(^|\\b)\\* int func\\(($|\\b)" (and "*" "int" "func("))`).Equal(t, test("* int func(", SearchTypeKeyword)) | ||
| autogold.Expect(`(or "(^|\\b)\"foo bar\" bas qux($|\\b)" (and "foo bar" "bas" "qux"))`).Equal(t, test(`"foo bar" bas qux`, SearchTypeKeyword)) | ||
| autogold.Expect(`(or "(^|\\b)foo 'bar bas' qux($|\\b)" (and "foo" "bar bas" "qux"))`).Equal(t, test(`foo 'bar bas' qux`, SearchTypeKeyword)) | ||
| autogold.Expect(`(or "foo bar bas" (and "foo" "bar" "bas"))`).Equal(t, test("foo bar bas", SearchTypeKeyword)) |
Member
There was a problem hiding this comment.
Just curious, having the word boundaries seemed like nice property. Does this mean the boundaries are not as important as I thought?
Contributor
Author
There was a problem hiding this comment.
They did make a small positive difference in my tests. But after looking at more examples, it was not as critical as I thought. For example, our classic queries test server and bytes buffer still show the correct result from golang/go in second place. So it's nice to keep things simple and remove it.
stefanhengl
reviewed
Aug 6, 2024
Comment on lines
+722
to
+723
| Value: query, | ||
| Annotation: Annotation{Labels: Boost | Literal | Standard}, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #64207. In our old search semantics, quotes were interpreted literally. So a query like
"sourcegraph"would match only strings likefmt.Println("sourcegraph"). Now, both single and double quotes are used for escaping, and mean that the contents should be searched exactly.This PR makes sure to boost matches on quoted terms in result ranking. This way, users familiar with the old syntax are more likely to find what they're after.
Test plan
Adapted unit tests. Re-tested all queries from #64207 manually, plus these ones:
'sourcegraph'"sourcegraph"