This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Search: re-add support for 'lucky' patterntype#64293
Merged
Merged
Conversation
Contributor
Author
|
Note: we will show |
stefanhengl
approved these changes
Aug 6, 2024
stefanhengl
left a comment
Member
There was a problem hiding this comment.
We also removed "Lucky" from the list of allowed values of search.defaultPatternType. I guess we want to keep it that way?
Contributor
Author
I believe we will still honor existing settings with Is there anywhere else we disallowed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #64215, we removed support for smart search. We continued to allow the
smartsearch mode, but just execute withprecisebehavior. However, we started to throw an error forpatterntype:lucky(which is the old way of specifying smart search). It turns out thatluckymade its way into some search links and settings, causing those searches to fail.This PR restores support for
lucky, and remaps it tostandard. This preserves the semantics as much as possible (since smart search attempts a 'standard' search as its first rule).Closes SRCH-840
Test plan
New unit test case. Tested manually with
patterntype:luckyand checked semantics match `standard.