This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(search_jobs): progress reporting#64287
Merged
stefanhengl merged 2 commits intoAug 6, 2024
Merged
Conversation
Relates to #64186 With this PR we only show `83 out of 120 tasks` if the search job is currently processing. In all other states, we don't show this stats. This is a consequence of the janitor job. After aggregation, this data is not available anymore. I remove an unncessary restriction on the download of logs and results. Test plan: I ran a search job locally and confirmed that the progress message is only visible while the job is processing and that logs and downloads are always available.
…ile-search-job-is-in-status
jtibshirani
approved these changes
Aug 6, 2024
| return nil, err | ||
| } | ||
| return pointers.Ptr(exportPath), nil | ||
| exportPath, err := url.JoinPath(conf.Get().ExternalURL, fmt.Sprintf("/.api/search/export/%d.jsonl", r.Job.ID)) |
Contributor
There was a problem hiding this comment.
Just double-checking: the results and logs are still available while the job is in progress, right?
Member
Author
There was a problem hiding this comment.
yes. Results and logs are always available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #64186
With this PR we only show
83 out of 120 tasksif the search job is currently processing. In all other states, we don't show this stat. This is a consequence of the janitor job I recently added, because after aggregation, this data is not available anymore. User's can still inspect the logs and download results to get a detailed view of which revisions were searched.I also remove an unnecessary dependency of the download links on the job state.
Test plan:
I ran a search job locally and confirmed that the progress message is only visible while the job is processing and that logs and downloads are always available.
Changelog