This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore: Switch over to fake RepoStore in codenav tests#64284
Merged
Conversation
f2001b1 to
0ed6486
Compare
Reduce the exposed surface area with a smaller interface minimalRepoStore, and make sure we're using fakes in the tests which better document the intent, instead of using a mock repo store.
0ed6486 to
91100f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce the exposed surface area with a smaller interface minimalRepoStore,
and make sure we're using fakes in the tests which better document the intent,
instead of using a mock repo store. The fake makes sure that the methods are
mutually consistent, which is easier to do when working with a smaller interface.
Stacked on top of:(EDIT: Removed the below PR from the stack)the relationships between the RepoStore methods of interest.
Test plan
Existing tests should continue to pass