This repository was archived by the owner on Sep 30, 2024. It is now read-only.
refactor(svelte): Reduce logo complexity#64274
Merged
Merged
Conversation
There is no need to have a separate image file for dark mode. The SVG file can handle color switching itself.
camdencheek
reviewed
Aug 5, 2024
Comment on lines
+7
to
+11
| @media (prefers-color-scheme: dark) { | ||
| :root { | ||
| --text-color: #fff; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Do we set this when a user switches manually between light and dark? I was thinking this was just reading the OS theme
Contributor
Author
There was a problem hiding this comment.
I don't know how it works but it indeed worked when I switched manually.
Member
There was a problem hiding this comment.
I was uncomfortable not knowing how this works, so did some digging and found that applying .theme-light or .theme-dark also sets color-scheme, which is respected by prefers-color-scheme
camdencheek
approved these changes
Aug 5, 2024
camdencheek
left a comment
Member
There was a problem hiding this comment.
Approved pending question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need to have a separate image file for dark mode. The SVG file can handle color switching itself.
Test plan
Switched theme in the user menu and in the browser dev tools.