This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Svelte: make closing the welcome overlay more obvious#64256
Merged
Conversation
92fad5b to
a124d37
Compare
0xnmn
reviewed
Aug 5, 2024
| <div class="cta"> | ||
| <div> | ||
| <Button variant="primary" on:click={() => handleDismiss()}>Awesome. I’m ready to use it!</Button> | ||
| <!-- <a href="TODO">Read release notes</a> --> |
Member
Author
There was a problem hiding this comment.
This is from before. The original designs have a link to the release post, but that doesn't exist yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to this request, I modified the welcome banner to:
Fixes SRCH-837
Test plan
Manual test
screenshot-2024-08-02_19-01-17.mp4