This repository was archived by the owner on Sep 30, 2024. It is now read-only.
servicecatalog: remove searcher dep on database#64247
Merged
Merged
Conversation
Searcher doesn't speak to the database nor has it for a long time. Test Plan: The following command is empty go run ./dev/depgraph/ summary internal/database | grep 'cmd/searcher'
Member
Author
|
FYI here are the services which speak to the DB: I was also surprised at how many services are listed for redis. But this is a side-effect of us having a outbound HTTP request logger which connects to redis. |
bobheadxi
approved these changes
Aug 2, 2024
Member
There was a problem hiding this comment.
thanks!
@michaellzc maybe we could generate this list via the depgraph commands documented 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searcher doesn't speak to the database nor has it for a long time. See https://github.com/sourcegraph/sourcegraph/pull/61463
Test Plan: The following command is empty
go run ./dev/depgraph/ summary internal/database | grep 'cmd/searcher'