This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Svelte: welcome banner followups#64222
Merged
Merged
Conversation
camdencheek
commented
Aug 1, 2024
| </main> | ||
|
|
||
| <WelcomeOverlay | ||
| show={(process.env.PW_TEST === 'true' && !$welcomeOverlayDismissed) ?? false} |
Member
Author
There was a problem hiding this comment.
This PW_TEST thing wasn't actually doing what I thought it was, and caused the banner to not be shown at all when deployed.
| } | ||
| :global(.theme-dark) & { | ||
| background: var(--color-background, #f9fafb); | ||
| background: var(--color-background, #0f111a); |
Member
Author
There was a problem hiding this comment.
Used the wrong color for dark mode.
| }) | ||
| await this.page.addInitScript(() => | ||
| window.localStorage.setItem('temporarySettings', '{"webNext.welcomeOverlay.dismissed": true}') | ||
| ) |
Member
Author
There was a problem hiding this comment.
In playwright tests, don't ever show the overlay
|
|
||
| const showDeparture = !departureDismissed | ||
| // only show if the welcome message has been dismissed so we know they have been introduced to the new webapp | ||
| const showDeparture = !departureDismissed && welcomeDismissed |
Member
Author
There was a problem hiding this comment.
When a user is not in a default-on environment, we do not want to show the departure message if they have never activated the rewrite
vovakulikov
approved these changes
Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few followups from #64163. Comments inline.
Test plan
Manual local testing