This repository was archived by the owner on Sep 30, 2024. It is now read-only.
refactor: renames usage cursor and adds fields for future syntactic cursor#64208
Merged
Conversation
| PreciseCursor Cursor `json:"pc"` | ||
| CursorType CursorType `json:"ty"` | ||
| PreciseCursor PreciseCursor `json:"pc"` | ||
| SyntacticCursor SyntacticCursor `json:"sc"` |
Contributor
There was a problem hiding this comment.
Maybe add a link to the open issue for pagination for search-based results?
| var nextPreciseCursor Cursor | ||
| switch currentCursor.PreciseCursorType { | ||
| var nextPreciseCursor PreciseCursor | ||
| switch currentCursor.CursorType { |
Contributor
There was a problem hiding this comment.
For the default case, add a panic or return an error.
varungandhi-src
approved these changes
Aug 1, 2024
04192c0 to
24ff699
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Landing this early to avoid accumulating conflicts
Test plan
Shouldn't change functionality as new fields are unused for now