Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

feat(search): Add support to all Apex language extensions#64194

Merged
mmanela merged 7 commits into
mainfrom
mmanela-graph-759-issue-with-apex-extension-not-appearing-for-langapex
Aug 1, 2024
Merged

feat(search): Add support to all Apex language extensions#64194
mmanela merged 7 commits into
mainfrom
mmanela-graph-759-issue-with-apex-extension-not-appearing-for-langapex

Conversation

@mmanela

@mmanela mmanela commented Jul 31, 2024

Copy link
Copy Markdown
Contributor

Part of GRAPH-759

Linguist only supports a subset of the file extensions often used for the Apex programming languages. This PR adds support for the main set commonly used.

Key changes

  1. Adds all extensions for Apex
  2. Update our logic to handle multiple extensions for one language
  3. Update tests to ensure we only manually map languages if they don't exist OR have different extensions in go-enry (prevents us from duplicating entries completely from go-enry)

Test plan

  • Update unit tests
  • Validate locally by testing the language filter

Comment thread lib/codeintel/languages/extensions_test.go Outdated
mmanela added 2 commits August 1, 2024 10:48
…ng-for-langapex' of https://github.com/sourcegraph/sourcegraph into mmanela-graph-759-issue-with-apex-extension-not-appearing-for-langapex
@mmanela mmanela merged commit 772e149 into main Aug 1, 2024
@mmanela mmanela deleted the mmanela-graph-759-issue-with-apex-extension-not-appearing-for-langapex branch August 1, 2024 14:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants