This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Code intel: respect provenance when getting usages#64193
Merged
Conversation
camdencheek
commented
Jul 31, 2024
Comment on lines
+65
to
+68
| // Override Symbol.species to return Array instead of OccurrenceIndex | ||
| public static get [Symbol.species](): ArrayConstructor { | ||
| return Array | ||
| } |
Member
Author
There was a problem hiding this comment.
Unrelated, but this fixes a nasty bug. Basically, calling filter on OccurrenceIndex would use the OccurrenceIndex constructor rather than the Array constructor to create a new object. This is not what we want because the OccurrenceIndex constructor does not have the same shape as the array constructor, and callers expect calling filter (an array method) to return an array
vovakulikov
approved these changes
Jul 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the new references panel to respect the provenance of an occurrence.
Fixes SRCH-792
Followups:
Test plan
Quick manual test that find references now only returns precise references if the occurrence has a precise provenance.