This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(search): correctly handle select:symbol.enum#64170
Merged
Merged
Conversation
jtibshirani
commented
Jul 31, 2024
| "anonmember": lsp.SKField, | ||
| "recordfield": lsp.SKField, | ||
| "constructor": lsp.SKConstructor, | ||
| "enum": lsp.SKEnum, |
Contributor
Author
There was a problem hiding this comment.
Important part of the change: I added enum, enumerator, plus accessor, getter, methodalias, setter, singletonmethod
This is still pretty fragile overall. I'd love if there was a standard, centralized mapping (that could do something like ctags -> SCIP -> LSP kinds?)
bahrmichael
approved these changes
Jul 31, 2024
keegancsmith
approved these changes
Jul 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To implement
select:symbol.enumfilters, we look at each symbol's ctags 'kind' and check if it matches the filter valueenum. We accidentally didn't include 'enum' in this match logic, so all these symbols were filtered away.This PR fixes that, and adds a few improvements:
symbol.LSPKindandsymbol.SelectKind, to avoid drift between these two conversions.Closes SPLF-178
Test plan
Adapted unit tests. Manually tested
select:symbol.enumbefore and after.Changelog
Fix a bug in
select:symbol.enumfilters where they returned no results