This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore: Unconditionally call endObservation#64150
Merged
Merged
Conversation
This was referenced Jul 30, 2024
kritzcreek
approved these changes
Jul 31, 2024
d869b5f to
35d9de5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the span will not be terminated if we don't call
endObservation.Not the end of the world since this span likely won't be useful,
but we should avoid skipping calls to
endObservationfor consistency.Stack on top of
Test plan
n/a