This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore(syntax-highlighter): Some cleanup for locals detection#64144
Merged
Conversation
added 3 commits
July 30, 2024 09:53
This lets us avoid a few String allocations and requires dealing with fewer lifetimes/borrows
This means we now consistently apply the fuel limit (we were missing a few loops before)
We now make sure to never enter references that ought to be skipped
keynmol
approved these changes
Jul 30, 2024
antonsviridov-src
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets us avoid a few String allocations and requires dealing with fewer lifetimes/borrows
AncestorsThis means we now consistently apply the fuel limit (we were missing a few loops before)
Silly me
We now make sure to never insert references that ought to be skipped in the first place
I'd recommend reviewing commit by commit, the changes aren't really related. Just didn't want to spam PRs for this.
Test plan
Snapshots continue to pass. Verified fuel limit is enforced by creating loopy trees on purpose. Ran some hyperfines on spring-framework to make sure perf didn't regress.