This repository was archived by the owner on Sep 30, 2024. It is now read-only.
SvelteKit: fix issue where clicking link with no href refreshed the page#64136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When clicking a menu item with no href, page refreshed every time. Now, menu items with no href cause no action when clicked.
Screen.Recording.2024-07-29.at.2.49.14.PM.mov
This is a follow up to this PR: https://github.com/sourcegraph/sourcegraph/pull/64134
Test plan
Manual/Visual testing
Changelog