Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

scip-syntax: Simplifies to two visibilities#64124

Merged
kritzcreek merged 3 commits into
mainfrom
christoph/no-pure-local-visibility
Jul 29, 2024
Merged

scip-syntax: Simplifies to two visibilities#64124
kritzcreek merged 3 commits into
mainfrom
christoph/no-pure-local-visibility

Conversation

@kritzcreek

Copy link
Copy Markdown
Contributor

Closes https://linear.app/sourcegraph/issue/GRAPH-774/see-if-we-can-get-away-with-2-visibilities-in-scip-syntax

Test plan

Snapshots don't change

A couple hyperfine runs suggest this is also slightly quicker

spring-framework on  HEAD (9409543) [?]
❯ hyperfine --warmup 3 'git archive HEAD | scip-syntax index tar - -l java' 'git archive HEAD | scip-syntax-main index tar - -l java'
Benchmark 1: git archive HEAD | scip-syntax index tar - -l java
  Time (mean ± σ):     909.9 ms ±   9.7 ms    [User: 7307.6 ms, System: 212.2 ms]
  Range (min … max):   902.4 ms … 935.2 ms    10 runs

Benchmark 2: git archive HEAD | scip-syntax-main index tar - -l java
  Time (mean ± σ):     939.6 ms ±   6.5 ms    [User: 7681.2 ms, System: 210.9 ms]
  Range (min … max):   931.2 ms … 952.1 ms    10 runs

Summary
  git archive HEAD | scip-syntax index tar - -l java ran
    1.03 ± 0.01 times faster than git archive HEAD | scip-syntax-main index tar - -l java

spring-framework on  HEAD (9409543) [?]
❯ hyperfine --warmup 3 'git archive HEAD | scip-syntax index tar - -l java' 'git archive HEAD | scip-syntax-main index tar - -l java'
Benchmark 1: git archive HEAD | scip-syntax index tar - -l java
  Time (mean ± σ):     916.4 ms ±  10.7 ms    [User: 7302.7 ms, System: 217.8 ms]
  Range (min … max):   905.4 ms … 939.9 ms    10 runs

Benchmark 2: git archive HEAD | scip-syntax-main index tar - -l java
  Time (mean ± σ):     945.4 ms ±   7.9 ms    [User: 7684.8 ms, System: 212.6 ms]
  Range (min … max):   935.0 ms … 959.3 ms    10 runs

Summary
  git archive HEAD | scip-syntax index tar - -l java ran
    1.03 ± 0.01 times faster than git archive HEAD | scip-syntax-main index tar - -l java

@kritzcreek kritzcreek requested a review from keynmol July 29, 2024 12:49
@cla-bot cla-bot Bot added the cla-signed label Jul 29, 2024
@github-actions github-actions Bot added team/graph Graph Team (previously Code Intel/Language Tools/Language Platform) team/product-platform labels Jul 29, 2024
@kritzcreek kritzcreek merged commit 195b8b3 into main Jul 29, 2024
@kritzcreek kritzcreek deleted the christoph/no-pure-local-visibility branch July 29, 2024 13:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed team/graph Graph Team (previously Code Intel/Language Tools/Language Platform) team/product-platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants