This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Blob search: Fix incorrect icons in the blob search bar#64108
Merged
Conversation
vovakulikov
approved these changes
Jul 26, 2024
vovakulikov
left a comment
Contributor
There was a problem hiding this comment.
cc @taiyab it looks like there is no ideal set of icons which would solve all our cases, makes me think that maybe we could fork lucide icon set and patch some icons manual and have @sourcegraph/icons instead (but this probably too much work)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch from Lucide icons to MDI which look better in this case.
Before:
After:
Test plan
Manual/Visual testing
Changelog