This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Enable p4-fusion by default for Perforce code host connections#64101
Merged
Conversation
…ast-src-170-enable-p4-fusion-by-default
…ast-src-170-enable-p4-fusion-by-default
eseliger
reviewed
Jul 30, 2024
eseliger
left a comment
Member
There was a problem hiding this comment.
I think in a second PR we can now also cleanup
to remove git-p4 and python (and then clean up the image_test.yaml in gitserver, too)
eseliger
approved these changes
Jul 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/sourcegraph/sourcegraph/pull/64147 adds the option to disable label conversion
Deprecates the
enabledsetting for the p4-fusion config and considers it as always on.Removed all checks and paths that lead to using
git p4.Test plan
Tests adjusted where necessary
Changelog
p4-fusionis now always enabled and the option for the much slower and unreliablegit p4no longer exists.