This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix(search_jobs): prevent job state flip-flopping between 'queued' and 'processing'#64098
Merged
Merged
Conversation
This fixes a bug in our status reporting where we would report a job as "queued" although it should be reported as "processing". In some cases this led to the state flip-flopping several times between "queued" and "processing". This happens, for example, if a worker has just finished a job (and set it to completed) but hasn't yet dequeued a new job. In this brief period we reported the entire search job as queued. Test plan: - updated unit test - manual testing
keegancsmith
approved these changes
Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SPLF-170
This fixes a bug in our status reporting where we would report a job as "queued" although it should be reported as "processing". In some cases this led to the state flip-flopping between "queued" and "processing".
This happens, for example, if a worker has just finished a repo-rev job (and set it to completed) but hasn't yet dequeued a new job. In this brief period we reported the entire search job as queued.
Test plan:
I ran the following search job which previously exhibited this behavior and verified that now it doesn't.