Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

fix/telemetry: silence invalid events that we already know about#64084

Merged
bobheadxi merged 4 commits into
mainfrom
telemetry-refactor-convert-to-tg-event
Jul 25, 2024
Merged

fix/telemetry: silence invalid events that we already know about#64084
bobheadxi merged 4 commits into
mainfrom
telemetry-refactor-convert-to-tg-event

Conversation

@bobheadxi

Copy link
Copy Markdown
Member

Adds a read-only "known baddies" list of feature/action combination where we know the event will produce marshalling or validation errors, and skips the error-logging step.

Note that the code fails the entire batch the way it works today, but in practice, none of our clients batch events yet, so this is something to fix when we start doing that.

Test plan

sg start enterprise
mutation {
  telemetry {
    recordEvents(
      events: [{feature: "cody.completion", action: "persistence:present", source: {client: "VSCode.Cody", clientVersion: "0.14.1"}, parameters: {version: 0, privateMetadata: 12}}]
    ) {
      alwaysNil
    }
  }
}

get an error response, but does not record a log in sg start output

@cla-bot cla-bot Bot added the cla-signed label Jul 25, 2024
@bobheadxi bobheadxi requested review from a team and dadlerj July 25, 2024 16:39

@jac jac left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bobheadxi bobheadxi merged commit 18313d5 into main Jul 25, 2024
@bobheadxi bobheadxi deleted the telemetry-refactor-convert-to-tg-event branch July 25, 2024 21:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants