This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore: Unify LsifStore.*SymbolUsages APIs into one#64076
Merged
Conversation
b291c78 to
b1dbff6
Compare
kritzcreek
suggested changes
Jul 25, 2024
kritzcreek
left a comment
Contributor
There was a problem hiding this comment.
Just one small change for consistency, but otherwise looks great!
Co-authored-by: Christoph Hegemann <christoph.hegemann@sourcegraph.com>
kritzcreek
approved these changes
Jul 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For precise usagesForSymbols, we want to propagate usages everywhere
(with associated symbol names, not just 'Location' values). This PR introduces
the new Usage type, and unifies the old GetBulkSymbolUsages and
GetMinimalBulkSymbolUsages APIs into a single GetSymbolUsages API.
We convert the Usage values to Location to avoid changing a lot of code at once.
We also change the DB query to do grouping and aggregation for us
instead of doing it in Go code.
Stepping stone for GRAPH-573
Test plan
Covered by existing tests