This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Syntactic indexing policy toggle: UI and supporting APIs (with backcompat)#64075
Merged
keynmol merged 4 commits intoJul 25, 2024
Merged
Conversation
keynmol
commented
Jul 25, 2024
| $retentionDurationHours: Int | ||
| $retainIntermediateCommits: Boolean! | ||
| $indexingEnabled: Boolean! | ||
| $syntacticIndexingEnabled: Boolean! |
Contributor
Author
There was a problem hiding this comment.
I believe this particular gql snippet is only used by the frontend, and it delegates to createCodeIntelligenceConfigurationPolicy mutations in the actual spec, where this field is optional.
But in the frontend we treat the field as required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GRAPH-751
Fixes GRAPH-636
Reverts sourcegraph/sourcegraph#64046 which itself was a revert of https://github.com/sourcegraph/sourcegraph/pull/63876 due to backwards compatibility concerns.
This new PR adds two extra commits which restore the
indexingEnabledfield, and makesyntacticIndexingEnabledfield optional.Fixes GRAPH-636
Fixes GRAPH-751
This PR aims to allow admins to enable syntactic indexing on per-policy basis using the existing UI and APIs with the following amendments:
To support this on the backend, we also update the policies handling code and SQL queries to ensure we can retrieve and update the
syntactic_indexing_enabledfield.Test plan
With experimental feature enabled:
With experimental feature disabled:
Changelog
indexingEnabledis renamed topreciseIndexingEnabledsyntacticIndexingEnabledis added (only takes effect if experimental feature is enabled)forIndexingis renamed toforPreciseIndexing