This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore(worker): move aggregated user stats job to worker#64033
Merged
Conversation
This moves the job from `frontend` to `worker`. Note: I believe there was a subtle bug in the orignal code. We only evaluated the feature flag on startup, which means that changes of the feature flag only took effect after a restart. Test plan: new unit test
eseliger
approved these changes
Jul 24, 2024
eseliger
left a comment
Member
There was a problem hiding this comment.
Nice find on the feature flag 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the job from
frontendtoworker.Note:
I believe there was a subtle bug in the original code. We only evaluated the
feature flag on startup, which means that changes of the feature flag
only took effect after a restart.
Test plan:
new unit test