This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore: Change some APIs to use symbols instead of monikers#64029
Merged
Conversation
varungandhi-src
commented
Jul 24, 2024
Comment on lines
358
to
361
Contributor
Author
There was a problem hiding this comment.
This function is basically 2 Map calls + a method call, which I've just inlined, as this was only used in 1 place.
kritzcreek
approved these changes
Jul 24, 2024
kritzcreek
left a comment
Contributor
There was a problem hiding this comment.
Nice. Just one small nit/question
Contributor
There was a problem hiding this comment.
Should the gomod appear in this symbol somewhere?
Contributor
Author
There was a problem hiding this comment.
The old code was just picking out the Identifier field, so I think this is OK.
symbolNames := make([]string, 0, len(monikers))
for _, arg := range monikers {
symbolNames = append(symbolNames, arg.Identifier)
}
query := sqlf.Sprintf(
bulkSymbolUsagesQuery,
pq.Array(symbolNames),
pq.Array(uploadIDs),
sqlf.Sprintf(usageKind.RangesColumnName()),
sqlf.Sprintf(usageKind.RangesColumnName()),
)
437d222 to
47521e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Monikers carry a bunch of redundant fields which basically consist of
information parsed out of the symbol name. This patch cleans up
some APIs to work with symbol names directly instead of monikers.
Stepping stone for GRAPH-573
Test plan
Covered by existing tests