This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore: Make location fetching queries more uniform#64026
Merged
Conversation
652cb10 to
8a145c2
Compare
8a145c2 to
74a91f5
Compare
kritzcreek
approved these changes
Jul 24, 2024
kritzcreek
left a comment
Contributor
There was a problem hiding this comment.
Following these %s's is tricky xD
Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch changes the location querying code so that:
(with "scheme" and "identifier" inside "MonikerData")
only to throw it away later.
comparison. When I land precise usagesForSymbol, I will de-duplicate
some of the scanning code between these two queries.
I have avoided renaming all of the local variables to avoid creating more noise.
Stepping stone for GRAPH-573
Test plan
Covered by existing tests.