This repository was archived by the owner on Sep 30, 2024. It is now read-only.
codeintel: fetches diffs from gitserver in batches#64025
Merged
Conversation
7 tasks
varungandhi-src
approved these changes
Jul 24, 2024
Contributor
There was a problem hiding this comment.
What's the reason behind changing this test case? Is this related to your point about "noticeable because tests need updates as we now use the path out of the returned diff"/I don't quite get that?
Contributor
Author
There was a problem hiding this comment.
Yes, exactly. The file diff iterator will only contain entries for files that have diffs, which means we can't rely on it giving us results we can zip with the input paths.
That means we have to rely on the file path contained in the diff, which means that in these tests we need to make sure to line up these file paths.
As we only searched for one path at a time previously the code would just handle the "empty iterator" as inputPath -> []diff{}.
17fdad2 to
5c778ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/sourcegraph/issue/GRAPH-769/fetch-diffs-in-batches
Test plan
Covered by existing tests (noticeable because tests need updates as we now use the path out of the returned diff)