This repository was archived by the owner on Sep 30, 2024. It is now read-only.
codeintel: returns surroundingContent from search result#64022
Merged
Conversation
Also limits the API to only return the line containing the match for now as discussed with Camden.
7 tasks
keynmol
approved these changes
Jul 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://linear.app/sourcegraph/issue/GRAPH-765/use-surroundingcontent-returned-from-the-search-client
The primary reason for doing this is to avoid sending a bunch of extra calls for file contents to gitserver, which dominate the profile/trace after implementing the remaining opts from https://github.com/sourcegraph/sourcegraph/pull/63971
Also limits the API to only return the line containing the match for now as discussed with Camden.
We might need to bring back the
lineGetterfor precise usages, but it should be easy enough to revive at that point /cc @varungandhi-srcTest plan
Updated unit tests, some manual testing in the API console