Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Update the outdated link to #dev-experience to #discuss-dev-infra#64018

Merged
BolajiOlajide merged 3 commits into
mainfrom
update-link-to-dev-experience-slack-channel
Jul 25, 2024
Merged

Update the outdated link to #dev-experience to #discuss-dev-infra#64018
BolajiOlajide merged 3 commits into
mainfrom
update-link-to-dev-experience-slack-channel

Conversation

@ykdojo

@ykdojo ykdojo commented Jul 23, 2024

Copy link
Copy Markdown
Contributor

Test plan

Test each link manually.

@cla-bot

cla-bot Bot commented Jul 23, 2024

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement (CLA), and we don't have yours on file. In order for us to review and merge your code, please sign CLA to get yourself added.

Sourcegraph teammates should refer to Accepting contributions for guidance.

@BolajiOlajide BolajiOlajide left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. The slack URL seems to point to the slack mobile client, it should look something like this

https://sourcegraph.slack.com/archives/C04MYFW01NV/p1721774059458429

I'm not 100% certain but that's my gut feeling

@cla-bot

cla-bot Bot commented Jul 23, 2024

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement (CLA), and we don't have yours on file. In order for us to review and merge your code, please sign CLA to get yourself added.

Sourcegraph teammates should refer to Accepting contributions for guidance.

@ykdojo

ykdojo commented Jul 23, 2024

Copy link
Copy Markdown
Contributor Author

@BolajiOlajide thank you!

Updated the link to the format you specified. Hope it looks better

@ykdojo ykdojo requested a review from BolajiOlajide July 23, 2024 23:19
@cla-bot cla-bot Bot added the cla-signed label Jul 25, 2024
@BolajiOlajide BolajiOlajide merged commit 09bd207 into main Jul 25, 2024
@BolajiOlajide BolajiOlajide deleted the update-link-to-dev-experience-slack-channel branch July 25, 2024 11:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants