Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Update the legacy link to sg doc#64017

Merged
ykdojo merged 6 commits into
mainfrom
update-lagcy-link-to-sg-doc
Aug 1, 2024
Merged

Update the legacy link to sg doc#64017
ykdojo merged 6 commits into
mainfrom
update-lagcy-link-to-sg-doc

Conversation

@ykdojo

@ykdojo ykdojo commented Jul 23, 2024

Copy link
Copy Markdown
Contributor

Test plan

Check each new link manually

@cla-bot

cla-bot Bot commented Jul 23, 2024

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement (CLA), and we don't have yours on file. In order for us to review and merge your code, please sign CLA to get yourself added.

Sourcegraph teammates should refer to Accepting contributions for guidance.

@cla-bot cla-bot Bot added the cla-signed label Jul 25, 2024
@ykdojo ykdojo requested a review from BolajiOlajide July 25, 2024 18:07
Comment thread client/web/README.md
## Local development

Use `sg` CLI tool to configure and start local development server. For more information check out [the `sg` documentation](https://docs-legacy.sourcegraph.com/dev/background-information/sg).
Use `sg` CLI tool to configure and start local development server. For more information check out [the `sg` documentation](https://github.com/sourcegraph/sourcegraph/blob/main/doc/dev/background-information/sg/index.md).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ykdojo

I think I'm lacking some context here.
Why are we moving from the legacy doc link to github?

If this is required, I think linking to a sourcegraph link is a better alternative to github.

@ykdojo ykdojo Jul 29, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking it might make sense to make sure it's up-to-date (as opposed to it being legacy).

I think linking to a sourcegraph link is a better alternative to github.

This sounds good! Happy to update the PR with it

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.

I think we can make use of a sourcegraph link instead of linking to GitHub then.

cc @jhchabran for viz

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated it. The hash links don't seem to work, though: https://sourcegraph.slack.com/archives/C05MW2TMYAV/p1722379724954569

@ykdojo ykdojo merged commit 83f553e into main Aug 1, 2024
@ykdojo ykdojo deleted the update-lagcy-link-to-sg-doc branch August 1, 2024 23:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants