Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

feat(codenav): Add symbol support for the Hack language#64015

Merged
mmanela merged 10 commits into
mainfrom
mmanela/graph-619-hack-symbol-side-bar-scip-ctags-or-universal-ctags
Jul 30, 2024
Merged

feat(codenav): Add symbol support for the Hack language#64015
mmanela merged 10 commits into
mainfrom
mmanela/graph-619-hack-symbol-side-bar-scip-ctags-or-universal-ctags

Conversation

@mmanela

@mmanela mmanela commented Jul 23, 2024

Copy link
Copy Markdown
Contributor

Adds scip-ctags support for the Hack language.

Noteworthy items

  1. I did not add support for modules since they are not supported in the tree-sitter grammar right now.

Screenshots

image

Test plan

  • Update unit tests
  • Manually validate symbol side bar for indexed commits
  • Manually validate symbol side bar for unindexed commits
  • Validate symbol search for indexed commits
  • Validate symbol search for unindexed commits

@keegancsmith keegancsmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

@mmanela mmanela requested a review from keynmol July 24, 2024 17:21
@mmanela mmanela marked this pull request as ready for review July 24, 2024 18:20
@mmanela mmanela requested a review from keynmol July 29, 2024 18:32
@mmanela mmanela changed the title feat(codenav): Add symbols support for the Hack language feat(codenav): Add symbol support for the Hack language Jul 30, 2024
@mmanela mmanela merged commit b2cd7e5 into main Jul 30, 2024
@mmanela mmanela deleted the mmanela/graph-619-hack-symbol-side-bar-scip-ctags-or-universal-ctags branch July 30, 2024 14:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants