This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat/frontend/dotcom: add toggles for various online license checks#64013
Merged
Conversation
eseliger
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the following toggles for various dotcom-mode online licensing capabilities:
DOTCOM_ENABLE_ONLINE_LICENSE_CHECKS=falsemakes it so that the license check "pings" always return "you're good to go"DOTCOM_ENABLE_ANOMALOUS_LICENSE_CHECKER=falsedisables the Redis + event_logs thing looking for suspicious pingsDOTCOM_ENABLE_UPCOMING_LICENSE_EXPIRATION_CHECKER=falsedisables Slack notifications for upcoming license expirationsAll defaults still respect the existing behaviour. https://github.com/sourcegraph/deploy-sourcegraph-cloud/pull/18712 explicitly sets the toggles for online license checks, per the discussion in https://sourcegraph.slack.com/archives/C012NU3PXA9/p1721669308549559
All of the above capabilities are planned to be migrated to Enterprise Portal:
Test plan
CI