Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

chore(bazel): disable stamping on rust_binary targets#64007

Merged
Strum355 merged 1 commit into
mainfrom
nsc/rust-binary-nostamp
Jul 23, 2024
Merged

chore(bazel): disable stamping on rust_binary targets#64007
Strum355 merged 1 commit into
mainfrom
nsc/rust-binary-nostamp

Conversation

@Strum355

@Strum355 Strum355 commented Jul 23, 2024

Copy link
Copy Markdown
Contributor

We don't appear to make use of the stamp values for any rust_binary targets, so lets not stamp it to save on cache invalidations

Test plan

$ bazel build --stamp --workspace_status_command=./dev/bazel_stamp_vars.sh $(bazel query 'kind("rust_binary", //...)')
...
$ sha256sum bazel-bin/docker-images/syntax-highlighter/scip-ctags bazel-bin/docker-images/syntax-highlighter/crates/scip-syntax/scip-syntax bazel-bin/docker-images/syntax-highlighter/syntect_server
...
$ bazel build $(bazel query 'kind("rust_binary", //...)')
...
$ sha256sum bazel-bin/docker-images/syntax-highlighter/scip-ctags bazel-bin/docker-images/syntax-highlighter/crates/scip-syntax/scip-syntax bazel-bin/docker-images/syntax-highlighter/syntect_server
...

observe identical checksums

Changelog

@Strum355 Strum355 requested review from a team July 23, 2024 12:16
@Strum355 Strum355 self-assigned this Jul 23, 2024
@cla-bot cla-bot Bot added the cla-signed label Jul 23, 2024
@Strum355 Strum355 enabled auto-merge (squash) July 23, 2024 12:17
@Strum355 Strum355 merged commit 49b9b10 into main Jul 23, 2024
@Strum355 Strum355 deleted the nsc/rust-binary-nostamp branch July 23, 2024 12:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@burmudar burmudar burmudar approved these changes

@varungandhi-src varungandhi-src varungandhi-src approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Strum355 Strum355

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Strum355 @burmudar @varungandhi-src