This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore(codeintel): Move RequestState construction to separate func#63998
Merged
Conversation
kritzcreek
suggested changes
Jul 23, 2024
kritzcreek
left a comment
Contributor
There was a problem hiding this comment.
Looks good once CI failures are handled (I think the indexLoaderFactory is now autoIndexJobLoaderFactory
kritzcreek
approved these changes
Jul 23, 2024
98d4213 to
d2ce271
Compare
c5eb611 to
33d32a1
Compare
d2ce271 to
14bd5ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separating out the logic into a different function so it can be reused
later for precise usagesForSymbol.
Stepping stone for GRAPH-573
Test plan
n/a