This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore(codeintel): Simplify code using upload filtering#63997
Merged
Conversation
3e4bed5 to
c5eb611
Compare
kritzcreek
suggested changes
Jul 23, 2024
kritzcreek
left a comment
Contributor
There was a problem hiding this comment.
Just one comment. Looks good otherwise.
Contributor
There was a problem hiding this comment.
From what I can tell this function never errors? Can we change its return type?
Contributor
Author
There was a problem hiding this comment.
I will be doing a separate cleanup pass later after landing precise usagesForSymbol, so leaving this as-is for now (this function isn't doing anything, it should not be adding a trace span at all)
kritzcreek
approved these changes
Jul 23, 2024
c5eb611 to
33d32a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of logic was constructing "visibleUpload" values but
it just needed to pass around CompletedUpload. Simplify that.
Stepping stone for GRAPH-573
Test plan
Covered by existing tests