Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

chore(search_jobs): improve description on main page#63992

Merged
stefanhengl merged 3 commits into
mainfrom
stefan-splf-159-improve-description-on-search-jobs-page
Jul 23, 2024
Merged

chore(search_jobs): improve description on main page#63992
stefanhengl merged 3 commits into
mainfrom
stefan-splf-159-improve-description-on-search-jobs-page

Conversation

@stefanhengl

Copy link
Copy Markdown
Member

The current description doesn't do a good job of explaining why Search Jobs is useful and how to create a job.

Test plan:

visual inspection

image

The current description doesn't do a good job of explaining why Search
Jobs is useful and how to create a job.

Test plan:
visual inspection
@cla-bot cla-bot Bot added the cla-signed label Jul 22, 2024
@github-actions github-actions Bot added team/product-platform team/search-platform Issues owned by the search platform team labels Jul 22, 2024
@stefanhengl stefanhengl requested review from a team and eseliger July 22, 2024 15:57
@stefanhengl stefanhengl marked this pull request as ready for review July 22, 2024 15:58

@eseliger eseliger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending two small comments

Comment thread client/web/src/enterprise/search-jobs/SearchJobsPage.tsx Outdated
Use search jobs if your goal is to obtain an exhaustive list of results from a large corpus.
Search jobs prioritize completeness over quick response times and results ranking.{' '}
<Link
to="help/code-search/types/search-jobs#using-search-jobs"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need a leading /?

@stefanhengl stefanhengl merged commit b2014e6 into main Jul 23, 2024
@stefanhengl stefanhengl deleted the stefan-splf-159-improve-description-on-search-jobs-page branch July 23, 2024 07:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed team/product-platform team/search-platform Issues owned by the search platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants