This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat(search): Enable improved symbol parsing for large repos (when using Rockskip)#63988
Merged
mmanela merged 23 commits intoJul 31, 2024
Conversation
mmanela
commented
Jul 22, 2024
stefanhengl
reviewed
Jul 23, 2024
…return proper parser
…lctags-and-is-not-using-scip
…is-not-using-scip' of https://github.com/sourcegraph/sourcegraph into mmanela-splf-165-rockskip-only-uses-universalctags-and-is-not-using-scip
keegancsmith
approved these changes
Jul 24, 2024
eseliger
reviewed
Jul 24, 2024
Co-authored-by: Keegan Carruthers-Smith <keegan.csmith@gmail.com>
jtibshirani
reviewed
Jul 30, 2024
…lctags-and-is-not-using-scip
jtibshirani
approved these changes
Jul 31, 2024
…lctags-and-is-not-using-scip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During an investigation, we saw that Rockskip was not using scip-ctags for symbol parsing when applicable. This means that
This PR attempts to solve this problem but updating Rockskip to re-use the ctags parser pool logic from symbol service.
Key Changes
Questions
Test plan