This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[fix] Fix being unable to add batch changes credentials when rate limited#63984
Merged
pjlast merged 5 commits intoJul 26, 2024
Conversation
eseliger
reviewed
Jul 22, 2024
eseliger
approved these changes
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Sourcegraph is applying rate limits for external requests, it becomes impossible to add batch changes credentials because the verification step of the add requires an external request to be made.
Now, instead of waiting indefinitely, a maximum timeout of 10 seconds is applied, and if the credentials could not be verified within that time, the credentials are saved regardless and a warning is displayed to the user:
Test plan
Manual tests.
Changelog