This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Implement server-side single-repo context fetching for RFC 969#63980
Merged
Conversation
This reverts commit 4f465e9.
janhartman
approved these changes
Jul 22, 2024
janhartman
reviewed
Jul 23, 2024
| } | ||
| success = true | ||
| res.contextItems = append(res.contextItems, items...) | ||
| partialErrors = append(partialErrors, pe...) |
Contributor
There was a problem hiding this comment.
This isn't thread safe - should we map (concurrently) first and then aggregate?
Contributor
Author
There was a problem hiding this comment.
Fair, let me use iter.Map
janhartman
approved these changes
Jul 23, 2024
janhartman
left a comment
Contributor
There was a problem hiding this comment.
Nice, thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements server-side part of AI-132, exposing a single-repo context endpoint backed by Zoekt.
Differences from the current Enterprise endpoint (that is left untouched):
Test plan