This repository was archived by the owner on Sep 30, 2024. It is now read-only.
chore: Rename URI -> DocumentPath#63979
Merged
Merged
Conversation
varungandhi-src
commented
Jul 22, 2024
|
|
||
| locations = append(locations, precise.LocationData{ | ||
| URI: uri, | ||
| DocumentPath: uri, |
Contributor
Author
There was a problem hiding this comment.
It's a bit weird to use DocumentPath: uri here, but we don't care about LSIF conversion. Let's look at user stats to see if people are still uploading LSIF; otherwise let's deprecate & delete the code.
I'll file a follow-up issue for this tomorrow.
Contributor
There was a problem hiding this comment.
I thought we made it so people can't actually upload lsif anymore, and we convert it to scip at the src-cli level?
EDIT: Oh, this is the lib code that ends up getting imported from src-cli.
kritzcreek
approved these changes
Jul 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you look at the code for
bulkMonikerResultsQueryandminimalBulkMonikerResultsQuery,you'll see that the last returned value is the
document_path. The value returnedwas directly used an
UploadRootRelPathelsewhere. So it makes sense to renamethe field from URI to
DocumentPath.Test plan
Covered by existing tests