This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat(bazel): read binary version info from accompanying files in OCI images instead of stamping //internal/version#63977
Merged
Conversation
2a48369 to
8560e3a
Compare
8560e3a to
da7cf2d
Compare
da7cf2d to
8777b2a
Compare
d930d39 to
8ce453f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/sourcegraph/issue/DINF-111/rework-how-we-inject-version-in-our-artifacts
Pros:
bazel query 'kind("go_library", rdeps(//..., //internal/version))' | wc -l== 523 Go packages when stamp variables cause a rebuildCons:
Before:
After:
Test plan
Lots of building & rebuilding with stamp flags, comparing execution logs & times
Changelog