This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[Backport 5.5.x] [fix] Only trigger externalAcctSignup event when a new user is created#63975
Merged
Conversation
pjlast
approved these changes
Jul 22, 2024
craigfurman
approved these changes
Jul 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently events are triggered whenever a user signs in with
http-headerauth. This is because of theGetAndSaveUserfunction always triggering an event.However, before the new telemetry events, these events were only created when a new user was created.
This PR brings the new telemetry code in line with the old telemetry code to stop the massive amounts of spam caused by this event.
Closes SRC-461
Test plan
Adjust expected events in unit test.
Changelog
http-headerauth would cause a massive amount of event logs spamBackport cd65951 from #63843