This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Svelte: Fix Safari 17.3 groupBy usage#63964
Merged
Merged
Conversation
peterguy
approved these changes
Jul 20, 2024
peterguy
left a comment
Contributor
There was a problem hiding this comment.
Thanks for catching this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, svelte build of Sourcegraph is broken on s2 and dotcom for users who use Safari 17.3 and lower
The problem is that we use the
Object.groupBymethod, which isn't supported in "old" Safari versions like 17.3 and lower. See caniuse documentation about this here https://caniuse.com/?search=groupBy (in the old Safari version this method is actually namedgroupToMapTest plan
Changelog