This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Svelte rollout: add toggles for svelte-enabled pages#63960
Merged
Conversation
camdencheek
commented
Jul 19, 2024
Member
Author
There was a problem hiding this comment.
Had to add a toggle to the svelte version. Copied the minimal amount from the wildcard toggle.
928ddff to
884c6de
Compare
ecf4b10 to
edf633b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the last bit of work before flipping the switch on dotcom. Implemented based on the behavior @taiyab and I aligned on this morning. Can definitely still use a little sparkle, but I'll let others follow up on that.
It adds a toggle button to all pages that we have a svelte version of. The toggle is off when you're in the react webapp and on when you're in the svelte webapp. It also updates the copy of the popover to be more appropriate for the dotcom crowd.
On a React page:
On a Svelte page:
Test plan
Tested locally that I can enable/disable the toggle to switch between pages, that it is persistent, and that it looks relatively consistent between the versions.