Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Remove references to modelconfig.sourcegraph.pollingInterval#63956

Merged
chrsmith merged 3 commits into
mainfrom
chrsmith/remove-refs-to-dynamic-model-updates
Jul 29, 2024
Merged

Remove references to modelconfig.sourcegraph.pollingInterval#63956
chrsmith merged 3 commits into
mainfrom
chrsmith/remove-refs-to-dynamic-model-updates

Conversation

@chrsmith

@chrsmith chrsmith commented Jul 19, 2024

Copy link
Copy Markdown
Contributor

As the next release of Sourcegraph approaches, and we get our ducks in a row for rolling out the modelconfig changes, we have cut the ability for the Sourcegraph backend to poll Cody Gateway for new LLM models. Instead, if configured to, the only "Sourcegraph-supplied models" will be what is embedded into the binary at build-time. (See internal/modelconfig/embedded.)

This PR removes any externally facing references to this capability. Since it wasn't actually implemented yet, this isn't actually going to change any functionality.

We'll add this capability in the next release, ~September. See PRIME-290.

Test plan

NA

Changelog

NA

@chrsmith chrsmith requested review from a team and emidoots July 19, 2024 17:34
@cla-bot cla-bot Bot added the cla-signed label Jul 19, 2024
@chrsmith chrsmith enabled auto-merge (squash) July 19, 2024 18:32
@chrsmith

Copy link
Copy Markdown
Contributor Author

Not sure why the e2e tests are failing. I'm back from being OOO and looking at this now.

@chrsmith chrsmith force-pushed the chrsmith/remove-refs-to-dynamic-model-updates branch from 3051b75 to 1ce8bfb Compare July 29, 2024 18:00
@chrsmith

Copy link
Copy Markdown
Contributor Author

Running bazel test //testing:e2e_test failed because I'm missing various env vars, which I assume are all configured correctly in CI/CD. So I just rebased on top of main and force-pushed, hoping/praying that it is some transient thing that has since been fixed.

@chrsmith chrsmith merged commit caa4301 into main Jul 29, 2024
@chrsmith chrsmith deleted the chrsmith/remove-refs-to-dynamic-model-updates branch July 29, 2024 23:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants