This repository was archived by the owner on Sep 30, 2024. It is now read-only.
[update] Remove sleep in goroutine for webhook handlers#63940
Merged
Conversation
eseliger
approved these changes
Jul 19, 2024
Comment on lines
+57
to
+58
| // TODO: Should we return errors here? We could receive a webhook for a repo | ||
| // that's not on Sourcegraph, so probably not? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since permission sync jobs are database backed, we no longer need to sleep in the webhook handler goroutines, since the permission sync jobs have a sleep time themselves.
Test plan
Tests still pass, no real functional changes.
Changelog